Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update misc.sh #312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update misc.sh #312

wants to merge 3 commits into from

Conversation

db-yaya
Copy link

@db-yaya db-yaya commented May 14, 2021

Please make sure all below checkboxes in the Mandatory section have been checked before submitting your PR (also don't forget to pay attention to the Depending on Circumstances section)

Mandatory

  • The commit message is an imperative and starts with a capital letter (for example, Add something, Remove something, Fix something, etc.).
  • I made sure I hadn't put a period at the end of the the commit message(s).

Depending on Circumstances

Some of the items in the section become mandatory if you are a first-time contributor and/or your changes are relevant to the items.

  • Adding a new parameter I didn't forget to reflect it in README.md.
  • Adding a new parameter or modifying an existing one I didn't break the alphabetical order.
  • Adding a new utility written in Python I didn't forget to reflect it in pieman/README.md.
  • Adding a new utility written in Python I didn't forget to increase the version number of the pieman package in pieman/setup.py, pieman/pieman/__init__.py and essentials.sh.
  • (for first-time contributors) One of the commits in the pull request adds me to the Acknowledgements section in AUTHORS.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant