Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[restream][1.1] - Updated Package #265

Merged
merged 5 commits into from
Jan 29, 2021

Conversation

danshick
Copy link
Member

Official release notes state:

- low-latency streaming of the reMarkable framebuffer
- support for reMarkable generation 1 and 2
- POSIX shell on host machine supporting linux, mac and windows
- Rust executable on reMarkable

It should be noted that the only actual code changes that took place since the version we most recently packaged were:

- Disable password authentication for ssh
- Add warning message on ssh failure

Both of these changes took place on the computer side script, so the real advantage of this update is to start building against the tagged releases instead of individual commits, and to update the toolchain version.

@danshick
Copy link
Member Author

I think it is also worth mentioning here that rien/reStream#41 has not been accepted yet, so we are still unable to remove the conflict with rm2fb.

@Eeems
Copy link
Member

Eeems commented Jan 27, 2021

I think it is also worth mentioning here that rien/reStream#41 has not been accepted yet, so we are still unable to remove the conflict with rm2fb.

:(

@rien
Copy link

rien commented Jan 28, 2021

I've created a new release: https://github.com/rien/reStream/releases/tag/1.1

The rust binary restream.rs and the script restream.sh now follow the same versions to avoid confusion.

@matteodelabre
Copy link
Member

I updated the version and took the liberty to remove the duplication of the version number in the source array. I also removed the part of the configure message that asks the user to link /home/root/restream to /opt/bin/restream since restream supports the standard Toltec location if I’m not mistaken.

@danshick
Copy link
Member Author

I've created a new release: https://github.com/rien/reStream/releases/tag/1.1

The rust binary restream.rs and the script restream.sh now follow the same versions to avoid confusion.

Thanks for the new release and for including rm2fb support!

@danshick
Copy link
Member Author

danshick commented Jan 29, 2021

I updated the version and took the liberty to remove the duplication of the version number in the source array. I also removed the part of the configure message that asks the user to link /home/root/restream to /opt/bin/restream since restream supports the standard Toltec location if I’m not mistaken.

Both changes look good to me. /opt/bin was added in my PR, so that message can be safely removed. I've also removed the rm2fb conflict!

Edit:

We can also update the release notes I mentioned above to include everything in the official 1.1 release message. Should that be duplicated here for inclusion?

@danshick danshick changed the title [restream][1.0] - Updated Package [restream][1.1] - Updated Package Jan 29, 2021
Copy link
Member

@matteodelabre matteodelabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed to work on rM1 and rM2.

@matteodelabre matteodelabre merged commit 80529d3 into toltec-dev:testing Jan 29, 2021
@1ykos
Copy link

1ykos commented Feb 1, 2021

I did install restream from toltec-testing and linked /root/restream to /opt/bin/restream but I'm getting an error message when running ./reStream.sh:

[...]
error: The following required arguments were not provided:B f=0/0   
    --height <height>
    --width <width>
    --bytes-per-pixel <bytes>
    --file <path>

USAGE:
    restream [OPTIONS] --height <height> --width <width> --bytes-per-pixel <bytes> --file <path>
[...]

I have no idea what the correct argument for --file would be, otherwise I could test more.

@danshick
Copy link
Member Author

danshick commented Feb 2, 2021

I have no idea what the correct argument for --file would be, otherwise I could test more.

You should have gotten the following message when installing.

This app is only the device-side half of reStream. The companion script for consuming the output of this app can be found at <https://github.com/rien/reStream>.

@1ykos
Copy link

1ykos commented Feb 2, 2021

That's what I did. I got ./reStream.sh from that link and ran it, which produced the error message that I showed. The version I need is probably not in master yet. To investigate further I tried running the executable on the device directly, but I don't know what to specify in the --file parameter, whereas the other parameters are mostly self-explanatory.

@danshick
Copy link
Member Author

danshick commented Feb 2, 2021

That's what I did. I got ./reStream.sh from that link and ran it, which produced the error message that I showed.

Ah, misread your last comment.

Current master branch of reStream has this line in the script.

https://github.com/rien/reStream/blob/57dcd7ca271df898471662c1bca0b8230ecb4e65/reStream.sh#L200

$fb_file is going to depend on which version of the rM you have, and whether or not you are using rm2fb. It (and all of the other arguments to this binary) gets set earlier in the conditional block between lines 100 and 129.

To investigate further I tried running the executable on the device directly, but I don't know what to specify in the --file parameter, whereas the other parameters are mostly self-explanatory.

I wouldn't recommend doing this. You'll just get a very overwhelming spam of ASCII/binary noise representing the contents of the framebuffer dumped into your console. It won't be human readable output even if it is working.

I think we need to see more of the output from ./reStream.sh before and after the error message.

@1ykos
Copy link

1ykos commented Feb 2, 2021

I think I was using an old version of ./reStream.sh somehow. Another pull fixed the issue, sorry for the inconvenience and thank you all for your work! It now works with fb2 on my rm2 too.

@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants