-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[restream][1.1] - Updated Package #265
Conversation
I think it is also worth mentioning here that rien/reStream#41 has not been accepted yet, so we are still unable to remove the conflict with rm2fb. |
:( |
I've created a new release: https://github.com/rien/reStream/releases/tag/1.1 The rust binary |
I updated the version and took the liberty to remove the duplication of the version number in the source array. I also removed the part of the configure message that asks the user to link |
Thanks for the new release and for including rm2fb support! |
Both changes look good to me. /opt/bin was added in my PR, so that message can be safely removed. I've also removed the rm2fb conflict! Edit: We can also update the release notes I mentioned above to include everything in the official 1.1 release message. Should that be duplicated here for inclusion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed to work on rM1 and rM2.
I did install [...]
error: The following required arguments were not provided:B f=0/0
--height <height>
--width <width>
--bytes-per-pixel <bytes>
--file <path>
USAGE:
restream [OPTIONS] --height <height> --width <width> --bytes-per-pixel <bytes> --file <path>
[...] I have no idea what the correct argument for |
You should have gotten the following message when installing.
|
That's what I did. I got |
Ah, misread your last comment. Current master branch of reStream has this line in the script. $fb_file is going to depend on which version of the rM you have, and whether or not you are using rm2fb. It (and all of the other arguments to this binary) gets set earlier in the conditional block between lines 100 and 129.
I wouldn't recommend doing this. You'll just get a very overwhelming spam of ASCII/binary noise representing the contents of the framebuffer dumped into your console. It won't be human readable output even if it is working. I think we need to see more of the output from |
I think I was using an old version of |
Official release notes state:
It should be noted that the only actual code changes that took place since the version we most recently packaged were:
Both of these changes took place on the computer side script, so the real advantage of this update is to start building against the tagged releases instead of individual commits, and to update the toolchain version.