V3 mass upgrade

[palfrey]

Mass upgrade to v3 to fix #950

[Eeems]

You chose v3.1 instead of v3.2 as it went to stable, which downgrades some packages. Since you are updating from v2 based images, it wouldn't matter as they would still mainly be upgraded. Let's use v3.2 instead so we can avoid the issues we swapped to stable to resolve.

[palfrey]

You chose v3.1 instead of v3.2 as it went to stable, which downgrades some packages. Since you are updating from v2 based images, it wouldn't matter as they would still mainly be upgraded. Let's use v3.2 instead so we can avoid the issues we swapped to stable to resolve.

Done

[Eeems]

All recipes that were changed will need their pkgver's rel (The number after the -) updated to trigger the package build.

[palfrey]

This also fixes #871 as a side-effect...

[Eeems]

We will need to get a new version of toltecmk pushed out to include upgrading to to resolve the build issues. It probably is worth just bumping absolutely everything when we do to make sure we didn't introduce any new issues. After we get the other PR merged I'll get the toltecmk version pushed, but it may be a bit. I'm not at home and mostly on mobile or a mobile hotspot

[Eeems]

0.3.5 should be released with your changes.

[palfrey]

Yay! With a small set of exceptions (folly, plato, retris) all of which have comments and links to their bug tickets, we have a working build with all the other 2.x packages on 3.x.

[Eeems]

I'll take a closer look and do some testing later this week.

[palfrey]

Tried deleting the Cargo.lock for those projects, and downgrading to the minimum versions, but you hit tomaka/hlua#226 (among other problems) when trying that.

[LinusCDE]

Odd. I was building with the 3.2 image.
But sometimes it seemed to want to update it. No clue how cross does it. Potentially it just bumped rust in that image to latest somehow.

And yeah, seems that going back with hlua would be hard, as before there were compilation errors due to the system library changing some function definitions.

[palfrey]

Odd. I was building with the 3.2 image. But sometimes it seemed to want to update it. No clue how cross does it. Potentially it just bumped rust in that image to latest somehow.

And yeah, seems that going back with hlua would be hard, as before there were compilation errors due to the system library changing some function definitions.

toltec-dev/toolchain#43 to get a newer rust with a 3.3 image appears to have sorted all of this out thankfully!

[Eeems]

Alright, we have them all building now this will take a while to test as there are quite a few packages, and will require testing on both OS 2.x and 3.x for both rM1 and rM2. If anybody wants to help, feel free to comment with what you've tested. We are only really looking for a quick install/uninstall test along with launching the app to make sure it runs and appears to perform it's basic functions. There is no need for an in depth test, although if you do that, make sure to raise any issues you find on the application's repository, unless it appears to be a packaging issue.

[palfrey]

I'm in progress testing things on my rm1 with OS 2.x, and will update this comment as I continue:

• bash-completion - LGTM
• bufshot - LGTM
• calculator - LGTM
• chessmarkable - LGTM
• display - LGTM (stub installs fine)
• doomarkable - LGTM
• draft - LGTM
• dumbskull - LGTM
• evtest - LGTM
• fbink - LGTM
• fingerterm - LGTM
• folly - LGTM
• fuse - not sure how to test, installs fine
• genie - LGTM
• gocryptfs - runs, not really tested
• harmony - LGTM
• iago - runs, not really tested
• keywriter - boots to blank screen (but I'm seeing this with the current version as well)
• lamp - LGTM
• libdlib - LGTM
• libvncserver - LGTM given vnsee works
• minesweeper - LGTM
• mmc-utils - seems to run, not sure how tot est
• nao - LGTM
• netevent - LGTM
• netsurf - LGTM
• plato - LGTM
• puzzles - LGTM
• recrossable - LGTM
• remarkable-splash - LGTM
• remarkable-stylus - don't have the relevant hardware, installs fine
• remux - LGTM
• restream - LGTM
• retris - LGTM
• rmfakecloud-proxy - LGTM
• rmservewacominput - boots, LGTM, not really tested
• rpncalc - LGTM
• sas - LGTM
• templatectl
  Installing this gets the following and it fails to install

Configuring templatectl.
//opt/lib/opkg/info/templatectl.postinst: line 998: warning: here-document at line 21 delimited by end-of-file (wanted `UNIT')
//opt/lib/opkg/info/templatectl.postinst: line 999: syntax error: unexpected end of file

This appears to be in add-bind-mount with the UNIT bit having been indented for some reason?
Not happening on the previous version

• vnsee - LGTM
• wikipedia - LGTM
• wordlet - LGTM
• zshelf - LGTM

So with the exception of templatectl having a weirdly borked postinst, all good here.

[palfrey]

templatectl issue is a build bug, see toltec-dev/build#60

[palfrey]

templatectl install works all fine now

[Eeems]

keywriter - boots to blank screen (but I'm seeing this with the current version as well)

This is because you haven't added any text yet. You would need to send keyboard events to type and add text.

fuse - not sure how to test, installs fine

You would use gocryptfs to test, as it uses the fuse module.

mmc-utils - seems to run, not sure how tot est

You can use mmc status get /dev/mmcblk1 on the rM1 and mmc status get /dev/mmcblk2 on the rM2

---

Testing on my rM2 on OS3:

• bash-completion
• bufshot
  • rm2fb flag not modifying rpath build#51 encountered
• calculator
• chessmarkable
• display
• doomarkable
• draft
• dumbskull
  • rm2fb flag not modifying rpath build#51 encountered
• evtest
• fbink
• fbink-doom
  • rm2fb flag not modifying rpath build#51 encountered
  • Will not output anything when run
• fingerterm
• folly
• genie
• harmony
  • rm2fb flag not modifying rpath build#51 encountered
• iago
  • rm2fb flag not modifying rpath build#51 encountered
• keywriter
• lamp
  • rm2fb flag not modifying rpath build#51 encountered
• libdlib
• libvncclient
• mines
  • rm2fb flag not modifying rpath build#51 encountered
• mmc-utils
• nao
  • rm2fb flag not modifying rpath build#51 encountered
• netevent
• netsurf
  • rm2fb flag not modifying rpath build#51 encountered
• plato
• puzzles
• recrossable
• remarkable-splash
• remux
• restream
• retris
• rmfakecloud-proxy
• rmservewacominput
• rpncalc
  • rm2fb flag not modifying rpath build#51 encountered
• simple
  • rm2fb flag not modifying rpath build#51 encountered
• templatectl
• vnsee
• wikipedia
• wordlet
  • rm2fb flag not modifying rpath build#51 encountered
• zshelf

[Eeems]

See the recent comments for the changes requested. After that I'm comfortable with the level of testing so I can approve and merge this PR. Please re-request my review when you are done addressing my comments.

[palfrey]

See the recent comments for the changes requested. After that I'm comfortable with the level of testing so I can approve and merge this PR. Please re-request my review when you are done addressing my comments.

Done, please re-review

[Eeems]

Done, please re-review

To request a re-review, github has a feature to update the status for me to know you are actually requesting a re-review without saying something in the comments:

It's the arrow circle icon next to my review status.