Fix for a certain failing relationship layout, fixes https://github.com/toluaina/pgsync/issues/397 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make flake happy?
updatd requirements
toluaina
reviewed
Dec 13, 2022
pgsync/querybuilder.py
Outdated
| foreign_key_columns: list = self._get_column_foreign_keys( | ||
| child._subquery.columns, | ||
| foreign_keys, | ||
| table=table, | ||
| schema=node.schema, |
There was a problem hiding this comment.
looks good to me. only thing I would suggest is to use child.schema here because we do allow cross schema queries. So the child could be in a different namespace.
toluaina
requested changes
Dec 13, 2022
|
thanks for a swift reply, done |
toluaina
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pass, for additional info, please refer to the issue #397