Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply recommended fix for the health api exception #410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

passionsfrucht
Copy link

Proposed change

Not a big change, but I applied the fix recommended in #392 (comment), tested it locally and suddenly the integration worked again.

I did not review the changes deeply, but the change looks sensible and other people seemed to have success stories with it.

Thus, I wanted to make it easier to apply if someone else needs a quick fix and for you, dear maintainer, to apply easier.

Due to massive time shortage, I did not have time to check deeper into the code's functionality.

All praise belongs to @pavelekg !

Type of change

  • Bugfix
  • New feature
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.:
    Unfortunately applying black on the repo resulted in many changes, thus I reverted the application
  • Tests have been added to verify that the new code works.
  • Documentation added/updated if required.

@tomaae
Copy link
Owner

tomaae commented Feb 27, 2025

I dont think this is a good solution, it may start ignoring errors we dont want ignored.
Maybe limiting it to only health endpoint and version 7.17+ could do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants