Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ログ出力機能の実装 #30

Merged
merged 1 commit into from
Nov 16, 2024
Merged

feat: ログ出力機能の実装 #30

merged 1 commit into from
Nov 16, 2024
+93 −30

Conversation

book000
Copy link
Member

@book000 book000 commented Nov 16, 2024

@book000 book000 requested a review from Copilot November 16, 2024 10:09
@book000 book000 enabled auto-merge (squash) November 16, 2024 10:09
@book000 book000 merged commit b77d402 into master Nov 16, 2024
3 checks passed
@book000 book000 deleted the feat/log branch November 16, 2024 10:09
Copilot
Copilot AI reviewed Nov 16, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

cmd/splashscreen-changer/log.go:13

  • The logParamPath parameter is dereferenced without checking if it is nil. This could lead to a runtime panic if logParamPath is nil. Add a nil check before dereferencing logParamPath.
if *logParamPath != "" {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ログファイルへのログ出力
1 participant
@book000