Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to #222: fix signatures of luaopen_* functions in hlua #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Follow up to #222: fix signatures of luaopen_* functions in hlua #223

wants to merge 1 commit into from

Conversation

fenollp
Copy link

@fenollp fenollp commented Jul 27, 2024

No description provided.

@fenollp
Follow up to tomaka#222: fix signatures of luaopen_* functions in hlua
f327e79 
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
@fenollp fenollp mentioned this pull request Jul 27, 2024
Merged
@tomaka
Copy link
Owner

tomaka commented Jul 27, 2024

Ah, I forgot to update the main library, which was definitely wrong.
These functions are not documented at all, but looking at their source code they push a table on the stack, so we don't want to just expose them. Instead, they should at least return a PushGuard.

@fenollp
Copy link
Author

fenollp commented Jul 27, 2024

Oh well, I'm just here to silence some compilation issues. To me it'd be fine if these fns continued to not return anything.

Looking at the code, I'm not confident at all in how I should create these PushGuards :) Maybe you can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fenollp @tomaka