Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: implement execution engine #179

Merged
merged 81 commits into from
Jul 12, 2020
Merged

engine: implement execution engine #179

merged 81 commits into from
Jul 12, 2020

Conversation

tsatke
Copy link
Contributor

@tsatke tsatke commented Jun 18, 2020 •
edited
Loading

Implement the engine (former executor) to take in an IR and represent the stated changes in a file format.

tsatke added 18 commits June 5, 2020 18:24
@tsatke
Remove executor
7ec53fa
@tsatke
Introduce engine
6bc9244 
Add a converter that allows primitive to byte conversion for most
primitive types.
@tsatke
Improve godoc
358fa9f
@tsatke
Fix typo
5cde671
@tsatke
Add a few decoding function to the converter
07c9ebc
@tsatke
Add a page abstraction
a06d5a9
@tsatke
Add a slotted page implementation
893a23c
@tsatke
Add delete and get method to page
0151cfd
@tsatke
Create blackbox tests
9d5644d 
Create a blackbox test suite that can check any page implementation for
validity.
@tsatke
Add test and support for deletion of cells
dffe4b6
@tsatke
Add missing godoc
bb06a43
@tsatke
Make cell count internal and add a dirty flag
089e19e
@tsatke
Add a page mock
7ae4eed
@tsatke
Implement a simple LRU page cache
457d4f3
@tsatke
Remove current page implementation
3dbee4e
@tsatke
Add v1 page implementation without store functionality
1cee316
@tsatke
Remove converter as it's obsolete
ca08f13
@tsatke
Add storage functionality
ff1faf0
@tsatke tsatke added feature New feature or enhancement component/engine Engine issues labels Jun 18, 2020
@tsatke tsatke added this to the v0.0.1 milestone Jun 18, 2020
@tsatke tsatke self-assigned this Jun 18, 2020
@tsatke tsatke mentioned this pull request Jun 18, 2020
Open
6 tasks
tsatke added 6 commits July 9, 2020 15:53
@tsatke
Make tests also compare a Go string
0c85613 
Tests now not only check the string representation of a command,
but also a Go string representation. This is, to enable developers,
to easily check whether the output is actually correct when recording
new tests.
@tsatke
Remove obsolete length check of parser errors
0e9a36e
@tsatke
Merge package ID from branch raft
c7a0170
@tsatke
Merge branch 'master' into engine
03257a2
@tsatke
Implement projection
164f492 
This unfortunately is kind of a god commit.
* remove result package and replace with engine.Table
* extend profiling and tests
* add column names to table
* fixture tests will write column names
* implement project evaluation
@tsatke
Add godoc
e14c42b
tsatke
tsatke commented Jul 10, 2020
View reviewed changes
internal/engine/error.go Outdated Show resolved Hide resolved
internal/engine/evaluate.go Outdated Show resolved Hide resolved
internal/engine/expression.go Outdated Show resolved Hide resolved
internal/engine/expression.go Outdated Show resolved Hide resolved
internal/engine/numeric_parser.go Outdated Show resolved Hide resolved
internal/engine/scan.go Outdated Show resolved Hide resolved
internal/engine/storage/page_manager.go Outdated Show resolved Hide resolved
@tsatke tsatke marked this pull request as ready for review July 10, 2020 10:51
@tsatke tsatke requested a review from tomarrell as a code owner July 10, 2020 10:51
@tsatke tsatke requested a review from SUMUKHA-PK July 10, 2020 10:52
@tsatke tsatke requested a review from ayzu July 10, 2020 11:07
@tsatke @SUMUKHA-PK
Update internal/engine/storage/db_test.go
8a51bd4 
Co-authored-by: Sumukha Pk <sumukhapk46@gmail.com>
@tsatke tsatke merged commit e8c3b86 into master Jul 12, 2020
@tsatke tsatke deleted the engine branch July 20, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SUMUKHA-PK SUMUKHA-PK SUMUKHA-PK approved these changes

@tomarrell tomarrell Awaiting requested review from tomarrell tomarrell is a code owner

@ayzu ayzu Awaiting requested review from ayzu

Assignees

@tsatke tsatke

Labels
component/engine Engine issues feature New feature or enhancement
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tsatke @SUMUKHA-PK