Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open browse view to the working directory of the currently open bview. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PJayB
Copy link

@PJayB PJayB commented Jan 5, 2021

I feel like this speeds up navigation in most cases.

One potentially controversial change is that this now sets the default cwd of new bviews to the parent directory of the file being opened. I hope this doesn't have any bad side-effects!

This also sets the default cwd of new bviews to the parent directory of the file
being opened.
@@ -2,6 +2,7 @@
#include <signal.h>
#include <time.h>
#include <termbox.h>
#include <libgen.h>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dirname is defined there

@tomas
Copy link
Owner

tomas commented Jan 6, 2021

I think I need to try this out before I give you a thumbs up. Great work though!

Copy link
Author

@PJayB PJayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thanks!

@@ -2,6 +2,7 @@
#include <signal.h>
#include <time.h>
#include <termbox.h>
#include <libgen.h>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dirname is defined there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants