Charset detection not default as utf-8

[alexburley]

#170

Basically a clone of this issue

https://www.w3.org/TR/encoding/ looks like utf-8 is now default?

Are you open to pull request?

[tomas]

Sure, go ahead!

[alexburley]

@tomas What's the testing situation. I've forked and set up tests but getting a lot of failures, is there any specific environment set up thats not in the Readme?

In particular

decoder.spec.js -> test B -> encodes to UTF-8

Fails off the bat.

[tomas]

Yeah I just pushed a commit that breaks everything, haha. Give me five minutes.

[tomas]

Ok, go ahead and pull.

[alexburley]

@tomas wicked thanks

[alexburley]

@tomas Would you be okay with installing nock as a dev dependancy? Useful for specifying test cases for decoding.

e.g.

const nock = require('nock');
const url = https://some.url.com
nock(url)
	.get('/')
	.reply(200, 'Magyarországi Fióktelepe', {
		'content-type': 'text/html; charset=EUC-JP',
	});

 needle.get(url, { decode: false }, function(err, resp) {
          ....
   })

[tomas]

Yeah, no prob.

[alexburley]

PR raised #308

[alexburley]

@tomas Thanks :) How are releases managed? Is there a timeline for when this will be published?

[alexburley]

@tomas any update?