Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix test failures in node v14-v16 #396

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

joeyparrish
Copy link
Contributor

@joeyparrish joeyparrish commented Mar 22, 2022

This fixes a failing socket cleanup test by destroying the request on
error. This test did not fail on node v17.

Closes #395

@joeyparrish joeyparrish changed the title fix: Fix Linux test failures fix: Fix test failures in node v14-v16 Mar 22, 2022
This fixes a failing socket cleanup test by destroying the request on
error.  This test did not fail on node v17.

Closes tomas#395
@tomas tomas merged commit ce96b7a into tomas:master Apr 7, 2022
@joeyparrish joeyparrish deleted the fix-linux-tests branch April 20, 2022 15:54
joeyparrish added a commit to joeyparrish/less.js that referenced this pull request Apr 20, 2022
The issue was traced upstream to needle, and resolved in:
 - tomas/needle#392
 - tomas/needle#394
 - tomas/needle#396
 - tomas/needle#398

Closes less#3693
iChenLei pushed a commit to less/less.js that referenced this pull request Apr 22, 2022
The issue was traced upstream to needle, and resolved in:
 - tomas/needle#392
 - tomas/needle#394
 - tomas/needle#396
 - tomas/needle#398

Closes #3693
lumburr pushed a commit to lumburr/less.js that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures on node v14-v16
2 participants