Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added query parameter to promise based get method #412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prasad610
Copy link

needle.get(
        url,
        needleOptions,
        callback
)

Needle.get does not expect any query parameters from needle options.

@tomas
Copy link
Owner

tomas commented Nov 17, 2022

Would you include a simple test?

Also, isn't it move obvious to call the option query instead of params?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants