Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "suggested change" #95

Open
nedtwigg opened this issue Jul 30, 2020 · 3 comments
Open

Add support for "suggested change" #95

nedtwigg opened this issue Jul 30, 2020 · 3 comments

Comments

@nedtwigg
Copy link

Spotless is a code autoformatter for many languages, and someone suggested adding support for violations-lib.

It would be awesome if violations-lib also supported suggested changes. If it did, then Spotless' console output could provide comments not only on which lines have format problems, but also on what they need to be changed to.

@tomasbjerre
Copy link
Owner

Sounds good. If so I would need a sample report to use for testning. Or you file a PR.

I also replied in you issue at Spotless.

@nedtwigg
Copy link
Author

Google's errorprone can generate a standard unified diff patch file. We can't do it currently, but we could pretty easily build to that spec.

@tomasbjerre
Copy link
Owner

Ok!

Should be possible with severity and message being hard coded to something.

public Violation(final ViolationBuilder vb) {

I am parsing a patch in a library using this library. Perhaps it should be moved to this library.
https://github.com/tomasbjerre/violation-comments-lib/blob/master/src/main/java/se/bjurr/violations/comments/lib/PatchParser.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants