chore: implement missing tests

tomasvotava · Nov 4, 2024 · dffb35e · dffb35e
1 parent 2c353db
commit dffb35e
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 4 deletions.
diff --git a/tests/test_openid_responses.py b/tests/test_openid_responses.py
@@ -3,6 +3,7 @@
 import pytest
 
 from fastapi_sso.sso.base import OpenID, SSOBase
+from fastapi_sso.sso.discord import DiscordSSO
 from fastapi_sso.sso.facebook import FacebookSSO
 from fastapi_sso.sso.fitbit import FitbitSSO
 from fastapi_sso.sso.github import GithubSSO
@@ -219,6 +220,24 @@
             picture="https://avatars.yandex.net/get-yapic/123456/islands-200",
         ),
     ),
+    (
+        DiscordSSO,
+        {
+            "id": "test",
+            "avatar": "avatar",
+            "email": "test@example.com",
+            "global_name": "Test User",
+            "username": "testuser",
+        },
+        OpenID(
+            email="test@example.com",
+            first_name="testuser",
+            id="test",
+            picture="https://cdn.discordapp.com/avatars/test/avatar.png",
+            provider="discord",
+            display_name="Test User",
+        ),
+    ),
 )
 
 

diff --git a/tests/test_providers.py b/tests/test_providers.py
@@ -8,6 +8,8 @@
 from utils import AnythingDict, Request, Response, make_fake_async_client
 
 from fastapi_sso.sso.base import OpenID, SecurityWarning, SSOBase
+from fastapi_sso.sso.bitbucket import BitbucketSSO
+from fastapi_sso.sso.discord import DiscordSSO
 from fastapi_sso.sso.facebook import FacebookSSO
 from fastapi_sso.sso.fitbit import FitbitSSO
 from fastapi_sso.sso.generic import create_provider
@@ -20,12 +22,10 @@
 from fastapi_sso.sso.microsoft import MicrosoftSSO
 from fastapi_sso.sso.naver import NaverSSO
 from fastapi_sso.sso.notion import NotionSSO
+from fastapi_sso.sso.seznam import SeznamSSO
 from fastapi_sso.sso.spotify import SpotifySSO
 from fastapi_sso.sso.twitter import TwitterSSO
 from fastapi_sso.sso.yandex import YandexSSO
-from fastapi_sso.sso.seznam import SeznamSSO
-from fastapi_sso.sso.bitbucket import BitbucketSSO
-from fastapi_sso.sso.discord import DiscordSSO
 
 GenericProvider = create_provider(
     name="generic",

diff --git a/tests/test_providers_individual.py b/tests/test_providers_individual.py
@@ -1,6 +1,8 @@
+from unittest.mock import MagicMock
+
 import pytest
 
-from fastapi_sso import NotionSSO, OpenID, SSOLoginError
+from fastapi_sso import BitbucketSSO, NotionSSO, OpenID, SSOLoginError
 
 
 async def test_notion_openid_response():
@@ -23,3 +25,33 @@ async def test_notion_openid_response():
         await sso.openid_from_response(invalid_response)
     openid = OpenID(id="test", email="test@example.com", display_name="Test User", picture="avatar", provider="notion")
     assert await sso.openid_from_response(valid_response) == openid
+
+
+async def test_bitbucket_openid_response():
+    sso = BitbucketSSO("client_id", "client_secret")
+    valid_response = {
+        "uuid": "00000000-0000-0000-0000-000000000000",
+        "nickname": "testuser",
+        "links": {"avatar": {"href": "https://example.com/myavatar.png"}},
+        "display_name": "Test User",
+    }
+
+    class FakeSesssion:
+        async def get(self, url: str) -> MagicMock:
+            response = MagicMock()
+            response.json.return_value = {"values": [{"email": "test@example.com"}]}
+            return response
+
+    openid = OpenID(
+        id=valid_response["uuid"],
+        display_name=valid_response["display_name"],
+        provider="bitbucket",
+        email="test@example.com",
+        first_name="testuser",
+        picture=valid_response["links"]["avatar"]["href"],
+    )
+
+    with pytest.raises(ValueError, match="Session is required to make HTTP requests"):
+        await sso.openid_from_response(valid_response)
+
+    assert openid == await sso.openid_from_response(valid_response, FakeSesssion())