Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Discord and Bitbucket providers #207

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

tomasvotava
Copy link
Owner

closes #159

authored by @afi-dev

afi-dev and others added 2 commits November 4, 2024 14:28
fix

Update fastapi_sso/sso/discord.py

Apply fix

Co-authored-by: Tomas Votava <info@tomasvotava.eu>

chore: resolve conflicts
@tomasvotava tomasvotava added the enhancement New feature or request label Nov 4, 2024
@tomasvotava tomasvotava self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (b240d0d) to head (dffb35e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   94.99%   95.36%   +0.37%     
==========================================
  Files          21       23       +2     
  Lines         539      583      +44     
==========================================
+ Hits          512      556      +44     
  Misses         27       27              
Files with missing lines Coverage Δ
fastapi_sso/__init__.py 100.00% <100.00%> (ø)
fastapi_sso/sso/bitbucket.py 100.00% <100.00%> (ø)
fastapi_sso/sso/discord.py 100.00% <100.00%> (ø)

@tomasvotava
Copy link
Owner Author

@afi-dev I hope you won't mind, it felt wrong to combine the docs changes with Bitbucket and Discord SSOs, on the other hand it was stupid of me to keep this on ice for so long. Thanks for the contribution!

@tomasvotava tomasvotava merged commit f790da3 into master Nov 4, 2024
25 checks passed
@tomasvotava tomasvotava deleted the 159-bitbucket-discord branch November 4, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants