Fix for using ngResource #188
Conversation
…e returned collection options.
|
Hm, interesting. In that case I think it would be better to emit an error message to console to notify developer? |
|
Not a bad idea...thinking about it now, maybe the API should be more forgiving. That is, if the object doesn't have either lat/lng just ignore it? On the other hand that may make it harder to debug. Processing the entire marker list means if you use something like ngResource or Restangular you have a bunch of extra fields on the returned object that aren't markers. Any ideas on a good way to handle this? |
|
oh wait, never mind, I forgot these two fileds are added by ngresources automatically ;p So I think it's safe to ignore them in that case. Otherwise, we should better emit a warning. Is there any way that we can detect whether an object is returned by ngresources? |
|
Another option may be to allow skipInvalidMarker config that will silently ignore any markers that don't have either lat or lng. |
|
Yes, introducing a config is probably the better solution (as an attribute maybe?). That way developer disable the forgiving mode in none production environment. I just notice that not only markers has this problem, but other attributes like paths also have the same problem. Thanks for bringing up this issue :) |
|
Closing this, as promise unwrapping is being deprecated. |
ngResource adds two fields to collections that are returned: $promise and $resolved.
This PR skips any markers with that name. I had to add this locally and figured others may run into the same issue if they are loading markers from an external service.
Technically, if someone actually named their marker either of those names it would skip, but that seems unlikely!