Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UITextField different textRect for editing and static text. #344

Open
sdkdimon opened this issue Mar 26, 2016 · 1 comment
Open

UITextField different textRect for editing and static text. #344

sdkdimon opened this issue Mar 26, 2016 · 1 comment

Comments

@sdkdimon
Copy link

Hi, i am have issue with custom UITextfield which has different textRect and editingTextRect.
In UITextField+NUI.m found override_editingRectForBounds

  - (CGRect)override_editingRectForBounds:(CGRect)bounds {
     return [self textRectForBounds:bounds];
} 

Seems to be it is a bug, i guess method implementation should be:

 - (CGRect)override_editingRectForBounds:(CGRect)bounds {
    return [self override_editingRectForBounds:bounds];
} 
@Stunner
Copy link
Collaborator

Stunner commented Mar 26, 2016

Good catch. If you submit a pull request we'd be happy to review it. If you could throw in some test cases as well that would be superb.

sdkdimon pushed a commit to sdkdimon/nui that referenced this issue Mar 26, 2016
…#344

UITextField+NUI.m fix override_editingRectForBounds method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants