Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License label #2

Closed
wants to merge 2 commits into from
Closed

Conversation

josephlord
Copy link

Renames the license file to MIT_LICENSE and adds title to the the contents of the file to make clear at a glance that it is MIT licensed. I couldn't spot any changes to the content of the license.

Obviously feel free to reject this or request that I remove these changes from GitHub as it is your license.

@mattt
Copy link

mattt commented Dec 5, 2012

FWIW, the convention on GitHub (from everything I've seen) is have a LICENSE file, with some reference to a project's licensing terms in the README.

@josephlord
Copy link
Author

I think its flexible although completely up to you. I've certainly seen
MIT_LICENSE in other projects:
https://github.com/sandro/specjour
https://github.com/jquery/jquery

My Pull request included two separate commits, one for the filename
change and one to put the title back into the file. You are welcome to
either or both.

You made the Hacker News frontpage for a while btw:
http://news.ycombinator.com/item?id=4878533

Joseph

On 05/12/2012 22:56, Mattt Thompson wrote:

FWIW, the convention on GitHub seems to be to have a |LICENSE| file,
with some reference to a project's licensing terms in the |README|.


Reply to this email directly or view it on GitHub
#2 (comment).

@tombenner
Copy link
Owner

Definitely agreed that the license should be more visible. I've added a reference to it in the README, as it should've been there previously. Thanks for spotting this ambiguity, @josephlord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants