Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISlider, UIToolbar and UIButton #52

Merged
merged 1 commit into from
Jan 9, 2013
Merged

Conversation

savage7
Copy link
Contributor

@savage7 savage7 commented Jan 9, 2013

UISlider
added implementation of UISlider
added all style able properties with exception of:

  • (void)setThumbImage:(UIImage *)image forState:(UIControlState)state;
  • (void)setMinimumTrackImage:(UIImage *)image forState:(UIControlState)state;
  • (void)setMaximumTrackImage:(UIImage *)image forState:(UIControlState)state;

UIToobar
added implementation of UIToobar

UIButton:
added disabled state for background image to UIButton renderer

added disabled state to UIButton renderer
tombenner added a commit that referenced this pull request Jan 9, 2013
UISlider, UIToolbar and UIButton
@tombenner tombenner merged commit 1622449 into tombenner:master Jan 9, 2013
@tombenner
Copy link
Owner

This is great! Many thanks for adding these!

I've added a couple more properties to Slider and Toolbar and renamed some of the properties slightly so that they're more consistent with the rest of NUI (e.g. renamed background-image-portrait-top to background-image-top, because it uses UIBarMetricsDefault, which is used for both portrait and landscape unless landscape is specified).

Eventually, the style grammar for setting barMetrics will look more like media queries (#3), which will remove the need for all of these additional properties and make this all a little cleaner.

@savage7
Copy link
Contributor Author

savage7 commented Jan 9, 2013

Do you have a better idea for all this UIControllState* rather than hardcoded implementation for all variants?

I would prefer something like this:
background-image: image.png normal;

@tombenner
Copy link
Owner

Agreed about trying to avoid hardcoded implementation of those. I was thinking that pseudo-classes (#39) would be a pretty natural way to handle them (similar to a:hover in CSS-world).

benvium added a commit to benvium/nui that referenced this pull request Jan 13, 2013
…+[NUIGraphics backButtonWithClass:]. Added and subtracted 0.5 judiciously from line position to make line clear
tombenner added a commit that referenced this pull request Jan 14, 2013
Fix for #52: Fix non-retina appearance of border created in +[NUIGraphics backButtonWithClass:]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants