Skip to content

Commit

Permalink
feat(GoogleMaps): get rid of mapProps
Browse files Browse the repository at this point in the history
BREAKING CHANGE: mapProps is no longer needed

  since map children components are now rendered inside a virtual
  container, we don't need funky wrapper div anymore.

  Before:

    <div {...props.containerProps} ref="googleMaps" />
      <div {...props.mapProps} ref="googleMaps" />
    </div>

  After:

    <div {...props.containerProps} ref="googleMaps" />
  • Loading branch information
tomchentw committed Apr 30, 2015
1 parent f07eb4b commit 7e338c2
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/GoogleMaps.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ class GoogleMaps extends EventComponent {
const {props} = this;

return (
<div {...props.containerProps}>
<div {...props.mapProps} ref="googleMaps" />
</div>
<div {...props.containerProps} ref="googleMaps" />
);
}

Expand All @@ -118,7 +116,6 @@ class GoogleMaps extends EventComponent {
GoogleMaps.propTypes = {
...EventComponent.propTypes,
containerProps: PropTypes.object.isRequired,
mapProps: PropTypes.object.isRequired,
};

GoogleMaps._registerEvents = createRegisterEvents(
Expand Down

0 comments on commit 7e338c2

Please sign in to comment.