Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react 0.14.0-beta3 #102

Closed
boosh opened this issue Aug 23, 2015 · 13 comments
Closed

Support react 0.14.0-beta3 #102

boosh opened this issue Aug 23, 2015 · 13 comments

Comments

@boosh
Copy link

boosh commented Aug 23, 2015

I'd do this myself but I'm a react noob... I'm getting errors about the import of findDOMNode after upgrading the dependency to react 0.14.0-beta3, and more errors after fixing that import...

@tomchentw
Copy link
Owner

#100 I think you could still using it.

@boosh
Copy link
Author

boosh commented Aug 24, 2015

Perhaps removing the dependency from package.json might be enough. When I tried upgrading the dependency in a fork I had these errors though, and it didn't work.

Have you tried with beta3 instead of just beta1?

@VonD
Copy link

VonD commented Aug 24, 2015

@boosh I'm using this fork for the moment without any errors : https://github.com/VonD/react-google-maps/tree/no-peer-dependency

@tomchentw
Copy link
Owner

@VonD you're awesome!

@boosh
Copy link
Author

boosh commented Aug 27, 2015

Hmm I get an error when I copy and paste the simple map example into my project with that branch:

TypeError: Cannot read property 'firstChild' of undefined

When I installed it, it complained about needing react 0.13 but it not being installed...

In 0.14 they've split the DOM stuff out of core, so perhaps this is the problem?

@tomchentw
Copy link
Owner

@boosh Did you use the fork from @VonD ?

@boosh
Copy link
Author

boosh commented Aug 29, 2015

Yeah. I still had problems with it for some reason.

@VonD
Copy link

VonD commented Aug 29, 2015

@boosh is by any chance react installed in the node_modules directory of the react-google-maps package ?

@tomchentw
Copy link
Owner

@VonD @boosh which version of npm are you using ?

@VonD
Copy link

VonD commented Aug 30, 2015

2.5.1

@boosh
Copy link
Author

boosh commented Aug 30, 2015

I was using 3.0.0 but I've downgraded. I'll test it when I get chance.

@tomchentw
Copy link
Owner

If you use 3.0.0. npm will flatten your dependencies into the top most node_modules.

tomchentw added a commit that referenced this issue Sep 30, 2015
* it should be only in peer dependencies
* Original commit: d7e000a
* Original author: @alexkuz
* Closes #109, Ref #102
tomchentw added a commit that referenced this issue Oct 8, 2015
* Closes #127, #102
* Ref #116

BREAKING CHANGE
* __React@^0.14__: upgrade React in peerDependencies
	* add __react-dom@^0.14__ to peerDependencies
@tomchentw
Copy link
Owner

Closed by 443a5fd and released v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants