We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In L81 (and other map/components}):
should be instead:
componentWillReceiveProps (nextProps) { if(typeof this.state.map === 'undefined') { const domEl = findDOMNode(this); const {containerTagName, containerProps, children, ...mapProps} = nextProps; const map = GoogleMapHolder._createMap(domEl, mapProps); this.setState({ map }); } }
otherwise will fail ES2015 eslinting
error Do not use setState in componentDidMount react/no-did-mount-set-state
The text was updated successfully, but these errors were encountered:
We really want it to happen in cDM because we need DOM node for google maps instance. Any ideas?
cDM
Sorry, something went wrong.
feat(GoogleMap): use callback style ref to initialize GoogleMap
965b961
* Ref #141 * https://facebook.github.io/react/docs/more-about-refs.html#the-ref-callback-attribute
Use callback style ref in the new refactoring branch #157 .
532816a
Released v4.6.0
Awesome work, and quick response. I will try it out.
No branches or pull requests
In L81 (and other map/components}):
should be instead:
otherwise will fail ES2015 eslinting
The text was updated successfully, but these errors were encountered: