Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SimpleChildComponent#_createOrUpdateInstance #55

Closed
tomchentw opened this issue May 17, 2015 · 4 comments
Closed

Refactor SimpleChildComponent#_createOrUpdateInstance #55

tomchentw opened this issue May 17, 2015 · 4 comments

Comments

@tomchentw
Copy link
Owner

I'd prefer to split out logics to two functions:
SimpleChildComponent#_createInstance
SimpleChildComponent#_updateInstance
So that subclasses are free and clear to modify
@tomchentw tomchentw mentioned this issue May 17, 2015
Merged
@wuct
Copy link
Collaborator

wuct commented May 17, 2015

It will be nice when we need to use google-maps-utilities, since the constructors of those utilities are not in global google.

@tomchentw
Copy link
Owner Author

Got it. Seems appealing to use google-maps-utilities too!

@tomchentw
Copy link
Owner Author

Closed for #88 .

@tomchentw
Copy link
Owner Author

Released v2.0.0 and v2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomchentw @wuct