Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for InfoBox #54

Merged
merged 3 commits into from
May 21, 2015
Merged

Support for InfoBox #54

merged 3 commits into from
May 21, 2015

Conversation

wuct
Copy link
Collaborator

@wuct wuct commented May 17, 2015

#50

tomchentw
tomchentw reviewed May 17, 2015
View reviewed changes
examples/gh-pages/scripts/components/basics/StyledMap.js
@@ -0,0 +1,45 @@
import React from "react/addons";
import {GoogleMaps} from "react-google-maps";
import InfoBox from "react-google-maps/addons/InfoBox"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ;

@tomchentw
Copy link
Owner

Please drop the commit 0187218 since we'll build it during release.

@tomchentw tomchentw mentioned this pull request May 17, 2015
Closed
tomchentw
tomchentw reviewed May 17, 2015
View reviewed changes
examples/gh-pages/scripts/components/basics/StyledMap.js

}

StyledMap.defaultProps = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#53

@wuct
Copy link
Collaborator Author

wuct commented May 18, 2015

Thanks @tomchentw!
I have removed a build file and fix an "unused" and a "missing ;", please review.

@tomchentw
Copy link
Owner

squash:
16e7c00 >> 4e52c6c
176ab42 >> 613e5ef

reword:
chore(examples): build an example for InfoBox

@wuct
Copy link
Collaborator Author

wuct commented May 19, 2015

@tomchentw I just squashed and reworded them, please review. Thanks.

@tomchentw
Copy link
Owner

Awesome!

tomchentw added a commit that referenced this pull request May 21, 2015
@tomchentw
Merge pull request #54 from wuct/infoBox
6ff6d19 
Support for InfoBox
@tomchentw tomchentw merged commit 6ff6d19 into tomchentw:master May 21, 2015
@tomchentw
Copy link
Owner

Released v1.3.0. Thanks @wuct !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuct @tomchentw