feat(InfoWindow): component with example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +66,6 @@ module.exports = React.createClass({ | |||
| }, | |||
|
|
|||
| _render (props, state) { | |||
| return null; | |||
| return (props.children)? props.children : null; | |||
There was a problem hiding this comment.
Wait, render can return an array?
There was a problem hiding this comment.
ok, I can fix this.
But I am not sure you want render just one or multiple?
multiple:
return (props.children)? React.DOM.span(null, props.children): null;
if just support one, there is another solution.
There was a problem hiding this comment.
IMO, it should render children (multiple). However, I'm wondering that a react component can return props.children directly. Is that defined in spec? I might miss it.
If the spec doesn't say so, yeah maybe wrap it into a span would be good.
|
Merge for now to upgrade to React |
tomchentw
added a commit
that referenced
this pull request
Nov 8, 2014
feat(InfoWindow): component with example
tomchentw
pushed a commit
that referenced
this pull request
Nov 18, 2015
cristiandley
added a commit
that referenced
this pull request
Jun 16, 2016
* Added Loading Libraries section #275 lot of people confused about this * Links to Google Maps Javascript API, adds intro to library import, uses double quotes consistently (#1) * Revert "Links to Google Maps Javascript API, adds intro to library import, us…" (#2) * Revert "Revert "Links to Google Maps Javascript API, adds intro to library import, us…"" (#3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.