Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more supported map options #121

Closed
wants to merge 2 commits into from
Closed

added more supported map options #121

wants to merge 2 commits into from

Conversation

bruno12mota
Copy link

Hey! There are more supported options which were being ignored in the composeOptions function. Added a few more that I used in my case.

Cheers!

@tomchentw
Copy link
Owner

Same reason for #112 here. For google.maps.Map only these props are controlled/uncontrolled and it's determined by the following lines:

export const mapControlledPropTypes = {
// [].map.call($0.querySelectorAll("tr>td>code"), function(it){ return it.textContent; }).filter(function(it){ return it.match(/^set/) && !it.match(/^setMap/); })
// https://developers.google.com/maps/documentation/javascript/3.exp/reference#Map

You should just use <GoogleMap options={{}} ....> or <GoogleMap defaultOptions={{}} ....> instead.

@tomchentw tomchentw closed this Sep 30, 2015
@bruno12mota
Copy link
Author

Oh, sorry. Makes sense, didn't see it on the documentation though, my bad.

Great work by the way 👍

@tomchentw
Copy link
Owner

Really sorry about that. Haven't find a good documentation tool yet. Any recommendations?

@bruno12mota
Copy link
Author

Well there isn't something that stands out for documentation out there for free at least. I'm building my project docs with Jekyll so that people can contribute later. This is how react does it as well https://github.com/facebook/react/tree/gh-pages

The pain is more in setting up the design for it, I'll be making a custom one for my project, it's all open source so you can use it for this repo of course :-)

tomchentw added a commit that referenced this pull request Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants