Let OverlayView be clusterd in MarkerClusterer
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `OverlayView` can represent any kind of overlay, including extremely custom markers, it makes sense to allow it to be clustered. For this to work, we only have to implement two functions of the `Marker` class: `getDraggable` and `getPosition`. The `MarkerClusterer` will call our `OverlayView`'s `setVisible` method as needed.
|
This will be great! |
|
@ziad-saab if you want see this in a repo check https://github.com/cristiandley/react-gl-maps we are trying to promote all this PR that are helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
OverlayViewcan represent any kind of overlay, including extremelycustom markers, it makes sense to allow it to be clustered. For this to work,
we only have to implement two functions of the
Markerclass:getDraggableand
getPosition.The
MarkerClustererwill call ourOverlayView'ssetVisiblemethod asneeded.