Unmounting an InfoBox removes all listeners. #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchentw
pushed a commit
that referenced
this pull request
Apr 20, 2017
|
Amend-commit ad4f0ee |
|
Released v6.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I want to address an obscure issue that arises from failing to clean up InfoBox listeners on unmount. Taking a look at the end of the file here: https://github.com/googlemaps/v3-utility-library/blob/master/infobox/src/infobox.js it seems there's more to do than simple
setMap(null)in order to removeInfoBoxfrom the map. In particular, all the listeners should be cleaned up. Perhaps callinginfoBox.close()on unmounting makes more sense here?