Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render virtual container same lifecycle #70

Merged
merged 2 commits into from
Jun 17, 2015
Merged

Fix render virtual container same lifecycle #70

merged 2 commits into from
Jun 17, 2015

Conversation

tomchentw
Copy link
Owner

Fixed #61

tomchentw added 2 commits June 17, 2015 13:26
@tomchentw
fix(VirtualContainer): propTypes.children should be renderable
a3d73af
@tomchentw
feat(GoogleMaps): render VirtualContainer as children
c9e1982 
* Fixes #61 and thanks to @idolize
* It seems that <VirtualContainer> can co-exist with the dom created by google.maps.Map.
* Since React use data-reactid to update children of <VirtualContainer>, there's little chance that the children of <GoogleMaps> will be cleared due to diff algorithm.
@tomchentw tomchentw force-pushed the fix-render-virtual-container-same-lifecycle branch from 313540d to c9e1982 Compare June 17, 2015 05:26
tomchentw added a commit that referenced this pull request Jun 17, 2015
@tomchentw
Merge pull request #70 from tomchentw/fix-render-virtual-container-sa…
4506282 
…me-lifecycle

Fix render virtual container same lifecycle
@tomchentw tomchentw merged commit 4506282 into master Jun 17, 2015
@tomchentw tomchentw deleted the fix-render-virtual-container-same-lifecycle branch June 17, 2015 06:06
@tomchentw
Copy link
Owner Author

Released as v1.5.0

@tomchentw tomchentw restored the fix-render-virtual-container-same-lifecycle branch June 17, 2015 06:09
@tomchentw tomchentw deleted the fix-render-virtual-container-same-lifecycle branch June 19, 2015 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomchentw