Retry app autoscaling policy create/update on ObjectNotFound error

Closes hashicorp#427.
tomelliff · Apr 10, 2019 · d082965 · d082965
1 parent 409a3dc
commit d082965
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/aws/resource_aws_appautoscaling_policy.go b/aws/resource_aws_appautoscaling_policy.go
@@ -261,13 +261,16 @@ func resourceAwsAppautoscalingPolicyCreate(d *schema.ResourceData, meta interfac
  var err error
  resp, err = conn.PutScalingPolicy(&params)
  if err != nil {
- if isAWSErr(err, "FailedResourceAccessException", "Rate exceeded") {
+ if isAWSErr(err, applicationautoscaling.ErrCodeFailedResourceAccessException, "Rate exceeded") {
  return resource.RetryableError(err)
  }
- if isAWSErr(err, "FailedResourceAccessException", "is not authorized to perform") {
+ if isAWSErr(err, applicationautoscaling.ErrCodeFailedResourceAccessException, "is not authorized to perform") {
  return resource.RetryableError(err)
  }
- if isAWSErr(err, "FailedResourceAccessException", "token included in the request is invalid") {
+ if isAWSErr(err, applicationautoscaling.ErrCodeFailedResourceAccessException, "token included in the request is invalid") {
+ return resource.RetryableError(err)
+ }
+ if isAWSErr(err, applicationautoscaling.ErrCodeObjectNotFoundException, "") {
  return resource.RetryableError(err)
  }
  return resource.NonRetryableError(fmt.Errorf("Error putting scaling policy: %s", err))
@@ -343,6 +346,9 @@ func resourceAwsAppautoscalingPolicyUpdate(d *schema.ResourceData, meta interfac
  if isAWSErr(err, applicationautoscaling.ErrCodeFailedResourceAccessException, "") {
  return resource.RetryableError(err)
  }
+ if isAWSErr(err, applicationautoscaling.ErrCodeObjectNotFoundException, "") {
+ return resource.RetryableError(err)
+ }
  return resource.NonRetryableError(err)
  }
  return nil