Preventing rpyc 5.x from installing on Python 3.5 #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you 'pip install rpyc' on Python 3.5, rpyc 5.0.0 will successfully install, but not work since it only supports Python 3.6+.
IIRC wheels don't actually contain or execute the setup.py. So the "if sys.version_info < (3, 6): " never actually executes on the installing system. The correct way is to specify python_requires. More info here: https://packaging.python.org/guides/dropping-older-python-versions/
Any chance you would also be willing to pull or republish 5.0.0? With this change, pip will instead select the previous version of rpyc that supports 3.5. So ideally that would be 4.1.5 instead of 5.0.0.
Thanks a ton for maintaining rpyc! We use it to test a bunch of embedded linux systems, many of which are sadly still on 3.5.