Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing rpyc 5.x from installing on Python 3.5 #429

Merged

Conversation

strainmike
Copy link
Contributor

Currently if you 'pip install rpyc' on Python 3.5, rpyc 5.0.0 will successfully install, but not work since it only supports Python 3.6+.

IIRC wheels don't actually contain or execute the setup.py. So the "if sys.version_info < (3, 6): " never actually executes on the installing system. The correct way is to specify python_requires. More info here: https://packaging.python.org/guides/dropping-older-python-versions/

Any chance you would also be willing to pull or republish 5.0.0? With this change, pip will instead select the previous version of rpyc that supports 3.5. So ideally that would be 4.1.5 instead of 5.0.0.

Thanks a ton for maintaining rpyc! We use it to test a bunch of embedded linux systems, many of which are sadly still on 3.5.

Currently rpyc 5.0.0 gets installed on Python 3.5 (IIRC setup.py isn't executed on the installed system for wheels).  This change will tell pip that this version isn't compatible with 3.5.
@comrumino
Copy link
Collaborator

I can publish a 5.0.1 and remove 5.0.0 from pip if that works for you?

@comrumino comrumino merged commit 1eaac28 into tomerfiliba-org:master Jan 11, 2021
@strainmike
Copy link
Contributor Author

I can publish a 5.0.1 and remove 5.0.0 from pip if that works for you?

That would fix it! Thanks!

@comrumino
Copy link
Collaborator

comrumino commented Jan 11, 2021

So, 5.0.1 is released. I "yanked" 5.0.0 which is like a soft deletion (it should result in python 3.5 users installing 4.1.5). Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants