Prevent auto_register in Server from being wrongly set to False #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #441
The attribute
auto_register
inServer
and its inherited classes is used to register/unregister the Server to a registry.If set to
True
, it will :1. set itself to
False
in the_register()
method2. spawn
_bg_register()
in the_register()
method3. call
registrar.unregister()
in theclose()
methodActions
1
and3
are conflicting because1
will prevent3
from ever happening.By removing
1
, the auto_register mechanism will work correctly, without any side-effects because it is not called anywhere else.Test case : I haven't had time to add one yet, but if necessary I will look into it.