Fix classic RPyC over classic RPyC bug #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of ModuleNamespace's `__getattr__` may throw a `ModuleNotFoundError` when accessing an attribute. This is unexpected behaviour and should be changed to throwing an AttributeError (per convention).
This may cause a variety of problems, for example, when trying to connect classic RPyC over RPyc and use any module, you get a `ModuleNotFoundError`.
In order to reproduce this error, start a slave service on localhost and execute the following code:
```rpyc.classic.connect('localhost').modules.rpyc.classic.connect('localhost').modules```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of ModuleNamespace's
__getattr__may throw aModuleNotFoundErrorwhen accessing an attribute. This is unexpected behaviour and should be changed to throwing an AttributeError when an attribute is not found (as defined in PEP 562).This may cause a variety of problems, for example, when trying to connect classic RPyC over RPyc and use any module, you get a
ModuleNotFoundError.In order to reproduce this error, start a slave service on localhost and execute the following code: