Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated documentation on _conn, on_connect, and on_disconnect #469

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Fix outdated documentation on _conn, on_connect, and on_disconnect #469

merged 1 commit into from
Dec 18, 2021

Conversation

gschaffner
Copy link
Contributor

Corresponds to changes introduced in RPyC 4.0.

Corresponds to changes introduced in RPyC 4.0.
@comrumino
Copy link
Collaborator

comrumino commented Dec 18, 2021

Nice catch! I might make a minor adjustment to keep the variable usage of self._conn vs self.conn consistent. Even so, I appreciate the contribution!

@comrumino comrumino merged commit 983050a into tomerfiliba-org:master Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants