Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased thread id struct to work on 64bit Linux, fixes #524 #525

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

mawenzy
Copy link
Contributor

@mawenzy mawenzy commented Feb 4, 2023

Fixes #524

Increase size of the struct which holds the threads id's, because these are 8 bytes long on 64bit Linux.

This allows the bind_threads option to work on Linux, but will break compatibility with any previous version of rpyc.

In rpyc/core/protocol.py:

 remote_thread_id, local_thread_id = brine.I4I4.unpack(message[:16])
 message = message[16:]

I am not sure why you used 16, since the '!LL' struct should only be 8 bytes long. But this is the right size for the '!QQ' struct

@comrumino
Copy link
Collaborator

Thank you for opening the PR. I totally forgot to commit and push some changes from one of my computers.... So, I combined our comments. Again, thanks!

@comrumino comrumino merged commit 1cea5ba into tomerfiliba-org:master Feb 17, 2023
@mawenzy mawenzy deleted the threading branch February 21, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bind_threads does not work on 64bit linux
2 participants