cmd.setenv has misleading name

[chaoflow]

setenv sounds like it sets the environment for cmd wheres it returns a new bound command with the environment set.

This does not set the environment of cmd:

import plumb.local
cmd = local['cmd']
cmd.setenv(FOO="foo")

Do you see a way to "fix" this? A linguistic hack would be not to see "set" as a verb...

[tomerfiliba]

with_env?
ls2 = ls.with_env(FOO="foo")

donno. but i dont' think it's that common to deserve attention.

-tomer

---

Tomer Filiba
tomerfiliba.com http://www.facebook.com/tomerfiliba
http://il.linkedin.com/in/tomerfiliba

On Tue, Jul 1, 2014 at 5:05 PM, Florian Friesdorf notifications@github.com
wrote:

setenv sounds like it sets the environment for cmd wheres it returns a
new bound command with the environment set.

This does not set the environment of cmd:

import plumb.local
cmd = local['cmd']
cmd.setenv(FOO="foo")

Do you see a way to "fix" this? A linguistic hack would be not to see
"set" as a verb...

—
Reply to this email directly or view it on GitHub
#136.

[AntoineD]

I also got bitten by this misleading, and the doc does not say that a new command is returned.

[tomerfiliba]

@chaoflow, @AntoineD - feel free to submit a pull request that updates the docs and/or provides a better name for it. with_env() or modified_env() sound good to me, but it's really a matter of taste.

[AntoineD]

I'll submit a PR

[tomerfiliba]

closed by #143