Python 3.5 and PyPy compatibility #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…behavior is not ideal for this case.
essary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
tomerfiliba
added a commit
that referenced
this pull request
Sep 15, 2015
Python 3.5 and PyPy compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for Python 3.5 beta, nightly (3.6), and PyPy 2 and 3. This includes several fixes to ensure that Plumbum is compatible with the upcoming Python 3.5 release. Travis tests have been added.
The biggest change is
getdocis different in 3.5+, now looking up inheritance trees for docs, so a custom version was added, based on the stdlib, sincecliuses__doc__for help strings. Also,getargspechas been removed, solib.getargspecnow usesgetfullargspecifgetargspecis missing, and truncates it.subprocessdoesn't always havemswindows, so using variable inplumbum.lib(it was imported already!).PyPy fixes were mostly in
plumbum.color, removing comparisons withisand strings, since those are not supported in the same way in PyPy.