Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#219 - Fix for invalid stat arg on FreeBSD #220

Merged
merged 6 commits into from
Sep 9, 2015

Conversation

astraw38
Copy link
Contributor

@astraw38 astraw38 commented Sep 8, 2015

No description provided.

@henryiii
Copy link
Collaborator

henryiii commented Sep 8, 2015

What about the almost matching lines directly above it, for _path_getuid, _path_getgid?

@henryiii henryiii added the Bug label Sep 8, 2015
@henryiii henryiii added this to the v1.6.0 milestone Sep 8, 2015
@henryiii
Copy link
Collaborator

henryiii commented Sep 8, 2015

Looks good to me. I'll leave it to @tomerfiliba for the final check.

PS, do you have direct access to a FreeBSD system? I'm curious as to how the default terminal works with plumbum.colors.

tomerfiliba added a commit that referenced this pull request Sep 9, 2015
Issue#219 - Fix for invalid stat arg on FreeBSD
@tomerfiliba tomerfiliba merged commit 8f95899 into tomerfiliba:master Sep 9, 2015
@tomerfiliba
Copy link
Owner

thanks

@astraw38
Copy link
Contributor Author

astraw38 commented Sep 9, 2015

@henryiii

Only SSH access unfortunately.

@henryiii
Copy link
Collaborator

henryiii commented Sep 9, 2015

@astraw38 Okay, thanks for checking. Thanks for the patch, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants