-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better test support #226
Better test support #226
Conversation
@tomerfiliba, you might want to set up an official appveyor account for the project, I have one monitoring my fork for testing the addition, but it's obviously HenryIII/plumbum. |
hey @henryiii , i merged in your other pull requests and now this one has a conflict |
Conflicts: tests/test_local.py
Fixed. There's an odd bug in Travis's Python 3.5 and dev, causing it to run the previous python when you run python, rather than python3; causing the tunnel test to fail on all versions (including ones that passed before) (and, I believe that's what's happening, I could be wrong). I'll see if I can fix that test later. |
I found the problem, it was a change in behavior for string arguments for Python's that were installed automatically by Travis (but not preinstalled ones). Fixed in master. |
I have added OSX builds to Travis and added Windows builds through Appveyor. Getting all builds to pass required a few changes:
ls
) will get fixed eventually. I did not add remote tests either (yet)nosetests
is interpreted as a batch file, I moved fromnosetests
topy.test
. It can run allunittest
andnosetests
out of the box, and can greatly improve future test writing in a simpler format if we want it to (and we can stop patchingunittest
in Py2.6!). For now, all tests were left alone.