Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts into the ExecutionModifiers #281

Merged
merged 3 commits into from
Jun 10, 2016
Merged

Conversation

fahhem
Copy link
Contributor

@fahhem fahhem commented Jun 9, 2016

This pipes run_proc's timeout argument farther up the stack.

I'm hoping the tests will catch if this hits any parts that don't accept timeout and I'll add it to those as well.

This pipes run_proc's timeout argument farther up the stack
@coveralls
Copy link

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.03%) to 80.167% when pulling ef188ae on fahhem:patch-1 into e287d46 on tomerfiliba:master.

@coveralls
Copy link

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.03%) to 80.167% when pulling 0b9e482 on fahhem:patch-1 into e287d46 on tomerfiliba:master.

@fahhem
Copy link
Contributor Author

fahhem commented Jun 10, 2016

Looks like the only failure in travis is due to Python nightly changing the string representation of ints. Should I fix that in this PR or a separate one?

@henryiii
Copy link
Collaborator

One PR is okay with me.
Henry

On Jun 10, 2016, at 11:20 AM, Fahrzin Hemmati notifications@github.com wrote:

Looks like the only failure in travis is due to Python nightly changing the string representation of ints. Should I fix that in this PR or a separate one?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #281 (comment), or mute the thread https://github.com/notifications/unsubscribe/AEZyyvHFv85MTqcRaanNSGJ31BGYRkrSks5qKSxKgaJpZM4IyeD-.

@coveralls
Copy link

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.004%) to 80.143% when pulling 0f505ad on fahhem:patch-1 into e287d46 on tomerfiliba:master.

@fahhem
Copy link
Contributor Author

fahhem commented Jun 10, 2016

Okay, the latest push should have passing tests

@henryiii
Copy link
Collaborator

Okay, I’ll look at it when I get off work.
Thanks!
Henry

On Jun 10, 2016, at 12:16 PM, Fahrzin Hemmati notifications@github.com wrote:

Okay, the latest push should have passing tests


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #281 (comment), or mute the thread https://github.com/notifications/unsubscribe/AEZyyrYViMFLtGbWnow9_31gLi4Frn6Iks5qKTlmgaJpZM4IyeD-.

@coveralls
Copy link

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.03%) to 80.167% when pulling 3499955 on fahhem:patch-1 into e287d46 on tomerfiliba:master.

@henryiii henryiii merged commit ad4d3e2 into tomerfiliba:master Jun 10, 2016
@fahhem fahhem deleted the patch-1 branch June 14, 2016 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants