-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeouts into the ExecutionModifiers #281
Conversation
This pipes run_proc's timeout argument farther up the stack
Looks like the only failure in travis is due to Python nightly changing the string representation of ints. Should I fix that in this PR or a separate one? |
One PR is okay with me.
|
Okay, the latest push should have passing tests |
Okay, I’ll look at it when I get off work.
|
This pipes run_proc's timeout argument farther up the stack.
I'm hoping the tests will catch if this hits any parts that don't accept timeout and I'll add it to those as well.