Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization functions and russian localization #339

Merged
merged 4 commits into from
Aug 21, 2017

Conversation

asmfreak
Copy link
Contributor

This PR fixes #335 - It adds gettext localization to all strings that are used in Application output.
Also as a test I've written russian localization. Any other language can be easily added.
This should be tested on py2.x and on Windows.

@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage decreased (-1.3%) to 79.804% when pulling 3dc7590 on ASMfreaK:master into de47645 on tomerfiliba:master.

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage increased (+0.06%) to 81.114% when pulling cfb67aa on ASMfreaK:master into de47645 on tomerfiliba:master.

@henryiii
Copy link
Collaborator

This looks great. I'll try to get it in in a day or two. Thanks!

@henryiii
Copy link
Collaborator

Would you mind changing the % formatting into {name} formatting? That would be more consistent than using both styles, and would be easier for translators to use (for example, if they need to reorder a pair of messages). The fact that Plumbum currently mixes both styles is a historical relic.

@asmfreak
Copy link
Contributor Author

I like braces formatting, too. Ok.

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.06%) to 81.114% when pulling ef883ce on ASMfreaK:master into de47645 on tomerfiliba:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 81.114% when pulling ef883ce on ASMfreaK:master into de47645 on tomerfiliba:master.

@henryiii
Copy link
Collaborator

LGTM.

@henryiii henryiii merged commit a39e7ba into tomerfiliba:master Aug 21, 2017
@henryiii
Copy link
Collaborator

Thanks!!!

@asmfreak
Copy link
Contributor Author

Yay~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I18N of cli.Application
3 participants