Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path.resolve() was missing 'self' #492

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Path.resolve() was missing 'self' #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa1c68b
bug fixes around 'nohup'
koreno Jan 20, 2020
d757b33
bug fix in Path.resolve
koreno Jan 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion plumbum/commands/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ def popen(self, args=(), **kwargs):
raise NotImplementedError()

def nohup(self,
command,
cwd='.',
stdout='nohup.out',
stderr=None,
Expand Down
2 changes: 1 addition & 1 deletion plumbum/commands/modifiers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def __rand__(self, cmd):
else:
stdout = self.stdout
append = self.append
return cmd.nohup(cmd, self.cwd, stdout, self.stderr, append)
return cmd.nohup(self.cwd, stdout, self.stderr, append)


NOHUP = _NOHUP()
Expand Down
2 changes: 1 addition & 1 deletion plumbum/path/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def _glob(self, pattern, fn):
results.extend(fn(single_pattern))
return sorted(list(set(results)))

def resolve(strict=False):
def resolve(self, strict=False):
"""Added to allow pathlib like syntax. Does nothing since
Plumbum paths are always absolute. Does not (currently) resolve
symlinks."""
Expand Down