fix support for win32 in iter_lines #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koreno
force-pushed
the
win32-iter-lines
branch
from
1cfed11 to
873daf6
Compare
|
Can you rebase on master, please? Fixed CI. |
|
updated
- Ofer
…On Sat, Mar 7, 2020 at 1:51 AM Henry Schreiner ***@***.***> wrote:
Can you rebase on master, please? Fixed CI.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#500?email_source=notifications&email_token=AABMCR2MHDCZDTMZJKHNJ4DRGGEATA5CNFSM4K3SVBWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEODGZWQ#issuecomment-596012250>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMCR2BMQN4KS6HKWTDBBLRGGEATANCNFSM4K3SVBWA>
.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature never worked on win32, since it doesn't support using
selectwith anything but sockets...The only way I found to implement it was to use two threads