Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Network Manager #355

Merged
merged 2 commits into from
Mar 24, 2019
Merged

Remove Network Manager #355

merged 2 commits into from
Mar 24, 2019

Conversation

darkdrgn2k
Copy link
Contributor

Closes #278

@darkdrgn2k darkdrgn2k requested review from makew0rld and benhylau and removed request for makew0rld March 23, 2019 02:39
@darkdrgn2k darkdrgn2k changed the base branch from develop to ygg-tunnel-ipv6 March 23, 2019 16:43
makew0rld
makew0rld reviewed Mar 24, 2019
View reviewed changes
Copy link
Contributor

@makew0rld makew0rld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't enough about this aspect of networking software to properly review this, but if you've tested it I feel fine about it.

@darkdrgn2k
Copy link
Contributor Author

Well do more testing as part of the ygg-tunnel work

@darkdrgn2k darkdrgn2k merged commit 9d27d43 into ygg-tunnel-ipv6 Mar 24, 2019
@darkdrgn2k darkdrgn2k deleted the removenm branch March 24, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makew0rld makew0rld makew0rld left review comments

@benhylau benhylau Awaiting requested review from benhylau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdrgn2k @makew0rld