Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Content License and Copyright holder as Footer #24

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

arunmathaisk
Copy link
Contributor

@arunmathaisk arunmathaisk commented Sep 13, 2024

[params]
showFooterLicense = true
licenseType = "CC BY-SA 4.0"
copyrightYear = "2024"
copyrightHolder = "Arun Mathai"

Screenshot 2024-09-14 at 12 37 16 AM

Solves #25

@tomfran
Copy link
Owner

tomfran commented Sep 14, 2024

Thank you for the pull request! I like the idea of your footer, but I think a more generic implementation would be better.

Something like:

[params]
showFooter = true|false // default to true
footerContent = "Custom MD footer content."

So basically the same we are doing for home intro content.

This would allow users to have a custom footer (something I am seeing a lot in the forks) and decide to hide it completely if needed.

Also, I don't like the idea of having two footer files, one with some logic would be more than enough.

@arunmathaisk
Copy link
Contributor Author

Makes sense.

@tomfran
Copy link
Owner

tomfran commented Sep 14, 2024

If you want to make those changes feel free to update the PR 👍

@arunmathaisk
Copy link
Contributor Author

arunmathaisk commented Sep 14, 2024

[params]
showFooter = true
footerContent = """
Hahahahah
"""
  • If showFooter is set to true and footerContent is not set, your default attribution is shown.
  • If showFooter is false, no footer is shown, not even the author attribution.

Example:

image

@tomfran Hope this is what you wanted :)

@tomfran
Copy link
Owner

tomfran commented Sep 15, 2024

This looks good, but the showFooter param must default to true for this change to be backward compatible.
So something like: if the param is not set or it's true, then show the footer.

@arunmathaisk
Copy link
Contributor Author

Lol. forgot about backward compatibility. Glad to see you care about it :)
Here take a look
ef9948b

@tomfran tomfran merged commit eaf952c into tomfran:main Sep 17, 2024
tomfran added a commit that referenced this pull request Oct 30, 2024
feat: Content License and Copyright holder as Footer
tomfran added a commit that referenced this pull request Oct 30, 2024
feat: Content License and Copyright holder as Footer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants