-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Content License and Copyright holder as Footer #24
Conversation
Thank you for the pull request! I like the idea of your footer, but I think a more generic implementation would be better. Something like:
So basically the same we are doing for home intro content. This would allow users to have a custom footer (something I am seeing a lot in the forks) and decide to hide it completely if needed. Also, I don't like the idea of having two footer files, one with some logic would be more than enough. |
Makes sense. |
If you want to make those changes feel free to update the PR 👍 |
Example: @tomfran Hope this is what you wanted :) |
This looks good, but the |
Lol. forgot about backward compatibility. Glad to see you care about it :) |
feat: Content License and Copyright holder as Footer
feat: Content License and Copyright holder as Footer
Solves #25