feat(dev): remote -b short option and other rename

tomjs · Jun 10, 2024 · 3f9922e · 3f9922e
1 parent d14fe9a
commit 3f9922e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/packages/vscode-dev/src/cli.ts b/packages/vscode-dev/src/cli.ts
@@ -33,7 +33,7 @@ cli
   .option('--dts-name [dtsName]', 'Specify the output file name of d.ts', {
     default: 'vscode.d.ts',
   })
-  .option('-b, --builtin [...builtin]', 'Builtin commands')
+  .option('--builtin [...builtin]', 'Builtin commands')
   .option('-w, --watch', 'Watch mode')
   .option('--verbose', 'Display verbose output')
   .action(async (cwd: string, options: CLIOptions) => {

diff --git a/packages/vscode-dev/src/gen.ts b/packages/vscode-dev/src/gen.ts
@@ -144,15 +144,15 @@ function getDtsType(types: string[]) {
 
 function getCommandDts(pkg: IExtensionManifest, opts: CLIOptions) {
   const commands = pkg?.contributes?.commands || [];
-  const command = getDtsType(commands.map(s => s.command));
-  const builtin = getDtsType([...new Set(opts.builtin || [])]);
-  if (!command && !builtin) {
+  const commandType = getDtsType(commands.map(s => s.command));
+  const builtinType = getDtsType([...new Set(opts.builtin || [])]);
+  if (!commandType && !builtinType) {
     return '';
   }
 
   return /* ts */ `
-  export type BuiltinCommand = ${builtin || 'undefined'};
-  export type UserCommand = ${command || 'undefined'};
+  export type BuiltinCommand = ${builtinType || 'undefined'};
+  export type UserCommand = ${commandType || 'undefined'};
 
   export namespace commands {
 
@@ -195,14 +195,14 @@ function getViewDts(pkg: IExtensionManifest) {
     return acc.concat(ids);
   }, [] as string[]);
 
-  const viewType = getDtsType(viewIds);
-  if (!viewType) {
+  const dtsType = getDtsType(viewIds);
+  if (!dtsType) {
     return '';
   }
 
   return /* ts */ `
   export namespace window {
-    type ViewId = ${viewType};
+    type ViewId = ${dtsType};
 
     export function registerTreeDataProvider<T>(viewId: ViewId, treeDataProvider: TreeDataProvider<T>): Disposable;
     export function createTreeView<T>(viewId: ViewId, options: TreeViewOptions<T>): TreeView<T>;

diff --git a/packages/vscode-dev/src/types.ts b/packages/vscode-dev/src/types.ts
@@ -31,6 +31,14 @@ export interface CLIOptions {
    * builtin commands
    */
   builtin?: string[];
+  /**
+   * A dot-separated identifier for the configuration
+   *
+   * When a section-identifier is provided only that part of the configuration
+   * is returned. Dots in the section-identifier are interpreted as child-access,
+   * like `{ myExt: { setting: { doIt: true }}}` and `getConfiguration('myExt.setting').get('doIt') === true`.
+   */
+  identifier?: string;
   /**
    * watch files change
    * @default false