feat: POC of adding subscription_name to metric labels #2279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for adding subscription_name (1:1 to subscription_id) for metrics. I don't have time to complete it for all the requirements, but if anyone is interested please take it over.
Applies to both of azure metrics and promitor's internal metrics.
How it works:
AzureScrapingSystemMetricsPublisher
adds associated subscription_name if there is a subscription_id label <- for promitor's internal metricsMetricSinkWriter
adds associated subscription_name if there is a subscription_id label <- for azure metrics