Make seconds optional in Date-Time and Time #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2022
|
Can someone tell me what the check is failing on? I have no idea what's going on there. |
|
@eksortso looks like some sort of CI has been hooked up to the repo but the configuration file it needs is missing. I guess it's a WIP endeavour. Doesn't appear to have anything to do with your commit. |
|
Hmm... I thought I'd pushed the pre-commit configuration and reformatting stuff. Lemme check what's up. |
abelbraaksma
suggested changes
May 9, 2022
ChristianSi
approved these changes
May 12, 2022
|
@pradyunsg Looks like we're good to go here. Any word on the pre-commit configuration? |
arp242
approved these changes
May 16, 2022
|
@pradyunsg It's been awhile. Anything else need done on this? |
|
@eksortso Looks like you're gonna have to resolve merge conflicts on this one. :) |
pradyunsg
approved these changes
Jul 30, 2022
|
@pradyunsg Just needed to resolve the changelog. Good to go now. Thanks! |
pradyunsg
changed the title
|
Thanks @eksortso! ^>^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the seconds portion of values with Offset Date-Time, Local Date-Time, and Local Time type to be omitted. Closes #671.
This PR replaces the older PR #696, which was written pre-v1.0.0. The exact same changes to the text in the specification and the ABNF appear in both PR's.