Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with raw multiline string is failing on Windows #22

Closed
ordian opened this issue Aug 5, 2017 · 1 comment
Closed

Test with raw multiline string is failing on Windows #22

ordian opened this issue Aug 5, 2017 · 1 comment
Labels
C-bug Category: Things not working as expected

Comments

@ordian
Copy link
Member

ordian commented Aug 5, 2017

        thread 'test_raw_multiline_string' panicked at 'assertion failed: `(left == right)`
  left: `Object({"firstnl": Object({"type": String("string"), "value": String("This string has a \' quote character.")}), "multiline": Object({"type": String("string"), "value": String("This string\nhas \' a quote character\nand more than\none newline\nin it.")}), "oneline": Object({"type": String("string"), "value": String("This string has a \' quote character.")})})`,
 right: `Object({"firstnl": Object({"type": String("string"), "value": String("This string has a \' quote character.")}), "multiline": Object({"type": String("string"), "value": String("This string\r\nhas \' a quote character\r\nand more than\r\none newline\r\nin it.")}), "oneline": Object({"type": String("string"), "value": String("This string has a \' quote character.")})})`', tests\test_valid.rs:54:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

reported by @Boddlnagg in comment

@ordian ordian added the C-bug Category: Things not working as expected label Aug 5, 2017
@Boddlnagg
Copy link

Copying my comment from the other thread:

Ah, the newline thing might be related to how git checks out the files.

Specifically, I have the git autocrlf setting enabled, and AppVeyor might not use that (which would surprise me, though), leading to different encoding of line endings on checkout.

@ordian ordian changed the title Correct tests with \r\n Test with raw multiline string is failing on Windows Aug 5, 2017
bors bot added a commit that referenced this issue Aug 5, 2017
23: fix(parser): replace windows newlines in ml_literal_string with \n r=ordian

Fixes #22.
@Boddlnagg can you confirm?
@bors bors bot closed this as completed in #23 Aug 5, 2017
epage added a commit to epage/toml_edit that referenced this issue Sep 27, 2024
…at-args

Have clippy warn about uninlined format arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Things not working as expected
Projects
None yet
Development

No branches or pull requests

2 participants