toml_edit produces invalid TOML

[messense]

See the reproduction here: https://github.com/messense/toml-edit-repro, cargo run outputs

[dependencies]
polars-error = { version = "0.32.0", path = "../polars-error" }
atoi = { workspace = true, optional = true }

[dependencies.
arrow ]
package = "arrow2"
git = "https://github.com/jorgecarleitao/arrow2"
# git = "https://github.com/ritchie46/arrow2"
rev = "9beabec8cfb5502582d31ab898fdd36e7af0873c"
# path = "../arrow2"
# branch = "duration_json"
version = "0.17.2"
default-features = false
features = [
  "compute_aggregate",
  "compute_arithmetics",
  "compute_boolean",
  "compute_boolean_kleene",
  "compute_cast",
  "compute_comparison",
  "compute_concatenate",
  "compute_filter",
  "compute_if_then_else",
]

the

[dependencies.
arrow ]

part is invalid TOML.

See also:

• Having newlines in the dependency list leads to invalid sdist directory. PyO3/maturin#1732
• sdist broken for 0.18.12 and 0.18.13 pola-rs/polars#10366

[epage]

This is a variant of #267 and I'd be tempted to close in favor of that and likely that is an issue we'll just be living with and not doing anything about.

The problem in this particular case is that we are providing a &mut and the user is overriding it. We cannot intercept this to change what is happening.

Our best option is to check every value on serialization and rewrite it behind the users back, leading to extra work and user confusion

Depending on where this is being done, a caller could just force-reformat the moved section or the entire toml.

[messense]

Thanks for the quick reply!

I think I can workaround it by calling doc2_deps.remove("arrow") first, so feel free to close this issue.